Skip to content

[Dev] TE cudagraph recompute#2694

Merged
buptzyb merged 11 commits into
NVIDIA:devfrom
buptzyb:robinz/dev_cg_recompute
Jan 16, 2026
Merged

[Dev] TE cudagraph recompute#2694
buptzyb merged 11 commits into
NVIDIA:devfrom
buptzyb:robinz/dev_cg_recompute

Conversation

@buptzyb

@buptzyb buptzyb commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Main PR #1920

We used to disable recompute in cudagraph scope. However, with TE PR 2518, recompute is compatible with cudagraph under some conditions, like there cannot be random numbers in the recomputed scope (see PyTorch issue 170535, need fixes on the PyTorch side). Therefore, this PR updates the cudagraph recompute checks and codepath.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb buptzyb self-assigned this Dec 17, 2025
@buptzyb buptzyb requested review from a team as code owners December 17, 2025 13:31
@copy-pr-bot

copy-pr-bot Bot commented Dec 17, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Robin Zhang <robinz@nvidia.com>
@yaox12 yaox12 added this pull request to the merge queue Jan 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 12, 2026
@yaox12 yaox12 enabled auto-merge January 13, 2026 01:21
@yaox12

yaox12 commented Jan 13, 2026

Copy link
Copy Markdown
Member

/ok to test 34770a8

@yaox12 yaox12 added this pull request to the merge queue Jan 13, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 13, 2026
Signed-off-by: Robin Zhang <robinz@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@buptzyb buptzyb added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@buptzyb

buptzyb commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 539925e

@yaox12

yaox12 commented Jan 15, 2026

Copy link
Copy Markdown
Member

/ok to test 0a095fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants