Use standard grain source build in t5x arm64 Dockerfile #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rosetta-PAX tests are red due to Pallas tests failing (on both A100 and V100): https://github.com/NVIDIA/JAX-Toolbox/actions/runs/7671181458/job/20910215878?pr=499#step:8:29 |
|
Given that the rosetta test failures seem unrelated (also happen on other PRs, also on x86 and afaict ultimately appear related to Pallas) I think we should be fine to merge this? |
gspschmid
force-pushed
the
gschmid/aarch64_t5x_cleanup
branch
from
9b543a1 to
8482c66
Compare
ashors1
pushed a commit
that referenced
this pull request
Feb 3, 2024
Thanks to @iindyk's recent fix in the copybara export of `grain` (see [this commit](google/grain@b02754d)) we no longer have to apply an intrusive patch in order to build grain from source as part of our T5X arm64 build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @iindyk's recent fix in the copybara export of
grain(see this commit) we no longer have to apply an intrusive patch in order to build grain from source as part of our T5X arm64 build.A small issue remains, since some of the tests rely on missing dependencies at runtime, so we disable those two (see these logs).
cc @yhtang @olupton