fix: count only in-range packets toward GOP length to prevent open-GO…#23
Merged
Merged
Conversation
…P HEVC range overlap Signed-off-by: pinjie <pinjiex@nvidia.com>
Collaborator
Author
|
/build |
1 similar comment
Collaborator
|
/build |
RmSchaffert
reviewed
May 25, 2026
|
|
||
| import utils | ||
|
|
||
| OPEN_GOP_SAMPLE = os.path.join(utils.get_data_dir(), "open_gop_variant", "moving_shape_open_gop_h265.mp4") |
Collaborator
There was a problem hiding this comment.
Please include the required .mp4 file for this test.
Signed-off-by: pinjie <pinjiex@nvidia.com>
Collaborator
|
Thanks! |
Collaborator
|
/build |
1 similar comment
Collaborator
Author
|
/build |
RmSchaffert
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug: HEVC open-GOP leading pictures were counted into the GOP length, making adjacent GOPs report overlapping
[first_frame_id, first_frame_id + gop_len]ranges and breaking every downstream consumer that treats this range as a coverage interval.C++ fix: Exclude leading pictures from the GOP-length count so
(first_frame_id, gop_len)becomes a clean non-overlapping partition of the display-index space.Store fix: Switched
SharedGopStore.put()'s dedup from a coverage query to an exact(video, first_frame_id, gop_len)` identity match, so its correctness no longer depends on the upstream non-overlap invariant.Type of Change
Please select (at least one):
Testing
Checklist for testing:
scripts/run_tests.shOptionally, add a brief description.
Documentation, Examples, Tutorials, Demos
Checklist for documentation:
Optionally, add a brief description.
Code Quality
Checklist for dependencies:
pyproject.tomlif/as neededOptionally, add a brief description.
Related Issues / Context
If applicable, link related issues, discussions etc.
DCO / Sign-Off
Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.
References
For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):
docs/guides/CONTRIBUTION_GUIDE.mddocs/guides/DEVELOPMENT_GUIDE.mddocs/guides/DOCUMENTATION_SETUP_GUIDE.mddocs/guides/FORMATTING_GUIDE.mdPlease also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.