Skip to content

fix for isaligned ragged failure #163 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix for isaligned ragged failure #163 #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7e920d
fix for isaligned ragged failure
jperez999 Nov 1, 2023
6719b40
fix comment and signing
jperez999 Nov 1, 2023
1c20c0a
fix comment and signing
jperez999 Nov 1, 2023
eee5a7a
downgrade python version for pip install
jperez999 Nov 9, 2023
0a3afd6
add a detectable version of python
jperez999 Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.11
cache: "pip"
cache-dependency-path: "**/**.txt"
- uses: pre-commit/[email protected]
8 changes: 7 additions & 1 deletion merlin/dataloader/tensorflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

from merlin.core.compat.tensorflow import tensorflow as tf
from merlin.dataloader.loader_base import LoaderBase
from merlin.table import TensorColumn, TensorflowColumn, TensorTable
from merlin.table import Device, NumpyColumn, TensorColumn, TensorflowColumn, TensorTable
from merlin.table.conversions import _dispatch_dlpack_fns, convert_col


Expand Down Expand Up @@ -135,6 +135,12 @@ def convert_batch(self, batch):
if inputs is not None:
inputs_table = self.create_table(inputs)
for col_name, col in inputs_table.items():
# fix for ragged column isaligned check failure
if col.is_ragged:
original_device = col.device
col = self.convert_col(col, NumpyColumn)
if original_device == Device.GPU:
col = col.gpu()
tf_inputs[col_name] = self.convert_col(col, column_type)

tf_target = None
Expand Down