Skip to content

Add Blossom Jenkins GPU CI (A10) and conda setup#128

Open
scal444 wants to merge 2 commits intoNVIDIA-Digital-Bio:mainfrom
scal444:blossom_take2
Open

Add Blossom Jenkins GPU CI (A10) and conda setup#128
scal444 wants to merge 2 commits intoNVIDIA-Digital-Bio:mainfrom
scal444:blossom_take2

Conversation

@scal444
Copy link
Copy Markdown
Collaborator

@scal444 scal444 commented Apr 6, 2026

Summary

Adds Blossom/Jenkins integration for this repo so GPU CI can run on pull requests against main:

  • Jenkinsfile: single A10 GPU pod (nvidia.com/gpu_type: A10), CUDA 12.6 devel image, verify GPU, checkout PR, then pip install + pytest under conda (admin/setup_conda_env.sh).
  • admin/setup_conda_env.sh: Miniforge + conda-forge stack (Python, RDKit, Boost, CMake, pytest, etc.) for the build container.

QA-style steps are not included here; those stay on GitHub Actions runners.

Test plan

  • Trigger Blossom CI on this PR and confirm stages through pytest succeed.

@scal444
Copy link
Copy Markdown
Collaborator Author

scal444 commented Apr 6, 2026

/build

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 6, 2026

Greptile Summary

This PR adds Blossom/Jenkins GPU CI infrastructure — a Jenkinsfile orchestrating the pipeline and admin/setup_conda_env.sh installing the conda environment. The previous review already flagged the main concerns (--no-check-certificate, missing else branch on PR state, missing trailing newline); the two remaining findings below are minor style/reliability notes.

Confidence Score: 5/5

Safe to merge; all remaining findings are P2 style/reliability suggestions.

The prior review's P1 issues (TLS verification bypass, missing error branch, missing newline) are the substantive blockers. The two new findings here are minor and do not block the primary CI path.

No files require special attention beyond the previously flagged items.

Important Files Changed

Filename Overview
Jenkinsfile Pipeline correctly handles Open/Merged states, but stage('Get Token') is outside try/catch, risking stuck commit statuses on credential failures.
admin/setup_conda_env.sh Conda env setup script; version variables are unquoted in the final install command, and --no-check-certificate (flagged in prior review) is still present.

Greploops — Automatically fix all review issues by running /greploops in Claude Code. It iterates: fix, push, re-review, repeat until 5/5 confidence.
Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal.

Reviews (2): Last reviewed commit: "Drop gpu_type selector, add 90-min timeo..." | Re-trigger Greptile

All A10 nodes were tainted/unschedulable. Remove the gpu_type pin for now
so the pod can land on any available GPU node. Wrap the pipeline in a
timeout so a scheduling hang surfaces as a failure instead of running
silently forever.
@scal444
Copy link
Copy Markdown
Collaborator Author

scal444 commented Apr 6, 2026

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant