-
Notifications
You must be signed in to change notification settings - Fork 2
Reorganize files #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Reorganize files #58
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,17 @@ | ||
| [package] | ||
| name = "torc-slurm-job-runner" | ||
| version = "0.7.0" | ||
| edition = "2024" | ||
| version.workspace = true | ||
| authors.workspace = true | ||
| license.workspace = true | ||
| edition.workspace = true | ||
| description = "Torc Slurm job runner for HPC environments" | ||
|
|
||
| [dependencies] | ||
| torc = { path = ".." } | ||
| clap = { version = "4.5.4", features = ["derive", "color"] } | ||
| env_logger = "0.11.1" | ||
| log = "0.4" | ||
| chrono = "0.4.38" | ||
| hostname = "0.4.0" | ||
| clap.workspace = true | ||
| env_logger.workspace = true | ||
| log.workspace = true | ||
| chrono.workspace = true | ||
| hostname.workspace = true | ||
| serde_json.workspace = true | ||
| signal-hook.workspace = true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Re-export commonly used types" was changed but it now says "Re-export model types explicitly". However, the list of re-exported types is quite extensive (over 30 types). Consider whether this is truly necessary or if a glob re-export with selective hiding might be more maintainable. If explicit exports are required for documentation or API stability, this is acceptable, but document the reasoning.