-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Grid RE and Emissions #628
base: develop
Are you sure you want to change the base?
Conversation
validators=[ | ||
MinValueValidator(2023), | ||
MinValueValidator(2025), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really not allow users to give a past year for this? What if we want to model a system that already exists to validate or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something, but users can give a year for this, it just has to be between 2025-2050 because those are the years for which Cambium has data. If they want to run a past year, they would need to supply their own custom emissions rates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I was thinking that if cambium has time steps every 5 years from 2025 to 2050 and the nominal year also covers the 4 years preceding, that users would be allowed to provide a start year from 2021 to 2050. Maybe that's wrong though.
This reverts commit eba4d40.
Inputs and outputs from:
Added
Changed