-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variable scenario filtering, and availability TS multiplier #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 78.49% 81.12% +2.63%
==========================================
Files 40 40
Lines 4078 4143 +65
==========================================
+ Hits 3201 3361 +160
+ Misses 877 782 -95
|
This looks good to me, but we should probably add a test to cover this case. Do we have a dataset we can run that hits these changes? |
So we don't have a database that covers this test case. I don't have access to plexos to make one. One idea would be to use a more complicated public file like the caiso's deterministic plexos file as a test case. But r2x fails to convert this atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you want to go ahead and merge the other branch before merging to main?
… output files (#122) 1. Added simple filtering logic to `PlexosParser._construct_buses()` to exclude islanded buses from being parsed from a `plexos` xml file, because islanded buses don't work in `Sienna` 2. Added simple sorting logic to output CSVs so that files created by `r2x` are can be more easily diff'd (previously, it seemed that `r2x` parsing was not deterministic, so running `r2x` on the same xml file would result in different orderings in output files. 3. Updated the `tables` dependency based on my own experience trying to set up `r2x` in January (can roll this back/ignore if addressed elsewhere) --------- Co-authored-by: pesap <[email protected]>
Fixes:
Fixes scenario filtering of variables by Band ID. We could potentially apply this filter to other Enum classes, but I didn't want to unnecessarily filter out data unless we knew that behavior was needed:
R2X/src/r2x/parser/plexos.py
Lines 1249 to 1258 in ebac92c
One of the paths for parsing TS data was missing a
* record['available']