Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geospatialscenario to geospatialscenario.py #157

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

tobin-ford
Copy link
Collaborator

Describe your changes

MoveGeospatialScenario to geospatialscenario.py. Skipped this in v0.5.0. Wrote testing for GeospatialScenario. Namespaces are unchanged.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 54.65116% with 156 lines in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (17d65c4) to head (0d0afee).

Files with missing lines Patch % Lines
pvdeg/geospatialscenario.py 39.53% 156 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #157      +/-   ##
===============================================
+ Coverage        61.77%   64.35%   +2.58%     
===============================================
  Files               39       40       +1     
  Lines             3950     4057     +107     
===============================================
+ Hits              2440     2611     +171     
+ Misses            1510     1446      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants