Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeospatialScenario autobuild KDtrees and restructure files #144

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

tobin-ford
Copy link
Collaborator

Describe your changes

Remove kdtree as a required argument from GeospatialScenario down-selection methods and classifiers. kdtree objects are now generated on the fly when required and saved back to the class instance so they do not have to be kept track of or rebuilt for each one of these calls.

Major Organization: GeospatialScenario class definition moved from scenario.py to geopspatialscenario.py to maintain reasonable file size for these classes.

Issue ticket number and link

Fixes # (issue)
implements request from #122 "remove KDtree from downselect calls. we should generate the kdtree from the scenario's metadata at runtime"

Type of change

Breaking Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized (confirm this on kestrel)
  • What's new changelog has been updated in the docs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.26721% with 192 lines in your changes missing coverage. Please review.

Project coverage is 65.17%. Comparing base (f7469ec) to head (5c1fe06).

Files with missing lines Patch % Lines
pvdeg/geospatialscenario.py 21.07% 191 Missing ⚠️
pvdeg/scenario.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #144      +/-   ##
===============================================
- Coverage        65.42%   65.17%   -0.26%     
===============================================
  Files               36       37       +1     
  Lines             3575     3612      +37     
===============================================
+ Hits              2339     2354      +15     
- Misses            1236     1258      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants