Documentation (Geospatial, Meteorological Data, Materials Access) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #136 +/- ##
===============================================
- Coverage 65.65% 65.42% -0.23%
===============================================
Files 36 36
Lines 3549 3575 +26
===============================================
+ Hits 2330 2339 +9
- Misses 1219 1236 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@tobin-ford - This is looking great! There are a few figures that haven't been created by us. Do we cite them properly?
There was a problem hiding this comment.
@tobin-ford - Did we cite where this figure is from?
There was a problem hiding this comment.
They are linked directly to the webpage from NREL. Let's wait to merge this until we get the new PVDeg logo today. Then we can add the logo back to the docs.
martin-springer
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Significant
User Guideimprovements. Added geospatial information with visual aids, added meteorological data page and materials access page.Issue ticket number and link
Fixes #128
Type of change
Please delete options that are not relevant.
Checklist before requesting a review