Kempe gap calc #114
Merged
Kempe gap calc #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed up the oxygen permeation json file
Started a oxygen ingress tool
Started making a diffusion class.
Writing the oxygen ingress code.
I got this to work to calculate oxygen ingress through an edge seal.
This is a work in progress tool for modeling oxygen ingress.
I added the diffusion.py file to this.
This will now do the calculation for oxygen ingress into a module through an edge seal and into an encapsulant. This is a 1-D calculation. More to come, but this is a stopping point.
This is a tool to run the 1-D oxygen ingress calculation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #114 +/- ##
===============================================
+ Coverage 65.16% 66.03% +0.86%
===============================================
Files 34 36 +2
Lines 3270 3392 +122
===============================================
+ Hits 2131 2240 +109
- Misses 1139 1152 +13 ☔ View full report in Codecov by Sentry. |
martin-springer
approved these changes
Aug 28, 2024
Just fixed a small formatting issue.
|
I am writing testing for this. |
This is a Json file for acetic acid permeation parameters.
Just some updates to the background xcel file used to create the Json files.
Creation of an H2O permeation Json file.
I'm deleting this because the oxygen ingress parameters are now in an Oxygen ingress parameter Json file. Just some more organization here.
Improvements and additions in the oxygen ingress parameter Json file.
fixed some formatting.
Fixed a capitalization error.
Fixed formatting.
martin-springer
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the creation of a 1-D diffusion calculator and a tool to use it. It is currently set up to do calculations through an edge seal and into an encapsulant.