Kempe standoff pull request (#58)

* Reworking of the standoff calculations

* standard updates

* Update weather.py

* Update xeff_demo.csv

* Create xeff_demo.xlsx

* Put in defaults in get_NSRDB

* typos fixed

* Changed standoff calculation to instead of just having 180 degrees south be the default azimuth, it will point north or 0 degrees by default in the southern hemisphere.

* Update spectral.py

* Massive changes here but for the most part it is all about the standoff calculation which is working. One change to be aware of is that the prior calculations were using the module surface temperature for the standoff calculation but now it is using the cell temperature calculation.

* improvement on temperature windspeedfactor fix

* adding pytest coverage instructions

* Wind height added

* Added in a field for wind height data to the demonstration weather data.

* Added in some if/then statements to put in a field for the wind speed measurement height. For the NSRDB it is set for 2m, for PVGIS it is set for 10m.

* Made it so it would delete the message indicating that Rh was being calculated once it is completed.

* Changed it to do a wind speed factor calculation based on the wind height in the meta data and the supplied power factor using appropriate defaults.

* Modified the fatigue calculator to work with the new wind speed exponent method.

* Update meta.json

* Update test_humidity.py

* Update test_standards.py

* Update test_temperature.py

* Update standards.py

* I found an error in the standoff calculation. It was previously using the module surface temperature and it should be using the module cell temperature. It makes the required standoff calculations a bit higher.

* Update standards.py

* Fixed some documentation for wind speed dependence and made it so the T98 calculation will default to equatorial facing, open rack and latitude tilt.

* Some documentation changes.

* Update temperature.py

* run pre-commit hooks

* adapt wind_height variable name to NSRDB

* keep wind_height in meta

* refactor eff_gap_parameters()

* fix typo in temperature models

* workflow update Node.js 16 to 20

---------

Co-authored-by: MDKempe <[email protected]>
Co-authored-by: Silvana Ovaitt <[email protected]>
Co-authored-by: Kempe <[email protected]>
Co-authored-by: Silvana Ovaitt <[email protected]>
Co-authored-by: Kevin Anderson <[email protected]>

.github/workflows/pytest.yml

@@ -20,9 +20,9 @@ jobs:
         ]
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install ${{ matrix.env }}
@@ -33,6 +33,6 @@ jobs:
       run: |
         python -m pytest --cov=./ --cov-report=xml
     - name: Upload coverage reports to Codecov
-      uses: codecov/codecov-action@v3
+      uses: codecov/codecov-action@v4
       env:
         CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

docs/sphinx/source/conf.py

@@ -23,6 +23,7 @@
 project = "pvdeg"
 copyright = "2023, NREL"
 author = "Alliance for Sustainable Energy, LLC"
+
 version = pvdeg.__version__