Update RUNS.md to improve consistency of parameter desc. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to be certain, I'd like this reviewing please.... It seems like the 3 main runs in this reference parameter description were no longer consistent with what we've been doing re: implementation of calc_tdiss . As it stood, there was a suggestion to use the default input wave drag file for GS1p1, as defined in the namelist_ref, but I believe we want the _fac2 version. For GS1p2, where we do calc_tdiss online, there was waffle about the slightly irrelevant input file, which was not used. I've attempted to replace some waffle with hopefully clearer waffle.
|
I've only edited the Runs.md , but as this is an important parameter reference file I would be grateful of a review please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to be certain, I'd like this reviewing please....
It seems like the 3 main runs in this reference parameter description were no longer consistent with what we've been doing re: implementation of calc_tdiss . As it stood, there was a suggestion to use the default input wave drag file for GS1p1, as defined in the namelist_ref, but I believe we want the _fac2 version. For GS1p2, where we do calc_tdiss online, there was waffle about the slightly irrelevant input file, which was not used.
I've attempted to replace some waffle with hopefully clearer waffle.