Skip to content

Bugfix for NOAA Grib Data: Convert to DataArray before merging data from two files #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timothyas wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix for NOAA Grib Data: Convert to DataArray before merging data from two files #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c148fb
need to grab data array after merge
timothyas Jan 12, 2026
91767af
add vertical levels that incur this line of code to the test suite
timothyas Jan 12, 2026
4f4c7e2
does this help
timothyas Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/integration/gfs.anemoi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,12 @@ source:
- t2m
- t
- gh
- q
- prmsl

levels:
- 100
- 500
- 1000
- 875

slices:
sel:
Expand Down
3 changes: 1 addition & 2 deletions tests/integration/gfs.base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ source:
- t2m
- t
- gh
- q
- prmsl

levels:
- 100
- 500
- 1000
- 875

slices:
sel:
Expand Down
7 changes: 4 additions & 3 deletions ufs2arco/sources/noaa_grib_forecast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,13 @@ def open_sample_dataset(
)
except:
thisvar = None
dslist.append(thisvar)
dslist = [xds for xds in dslist if xds is not None]

if thisvar is not None:
dslist.append(thisvar)
if len(dslist) == 1:
dsdict[varname] = dslist[0]
elif len(dslist) > 1:
dsdict[varname] = xr.merge(dslist)
dsdict[varname] = xr.merge(dslist)[varname]
else:
logger.warning(
f"{self.name}: Could not find {varname}, will stop reading variables for this sample\n\t" +
Expand Down
Loading