Conversation
…(mean, rms) errors, organized by sensor and platform for reanalysis experiment inter-comparisons
…explicit mpi4py send/recv (instead of bcast) calls to distribute filtered data frames to child processes
…to obs batch plotting
…t size to 12 and time axis label adjustments
…e subset of sensors for more frequent (i.e., daily) updates
amschne
changed the title
amschne
changed the title
…ay observer diagnostic overlapping time periods
…ay observer diagnostic overlapping time periods
… sbatch scripts out of the python package and into a new top level directory named batch_scripts
…ard list of experiments for radiance monitoring webpage
|
|
||
| from score_db import score_db_base | ||
|
|
||
| def run(make_plot=False, make_line_plot=True, select_array_metric_types=True, |
There was a problem hiding this comment.
Can you please clean up some of the comments in this function and run_line_plot? That will clear up how these functions work a bit.
|
|
||
|
|
||
| def main(): | ||
| #run() |
There was a problem hiding this comment.
Does the run() function get called at all? If not, that can be removed.
|
|
||
| self.timestamp_dict = dict() | ||
| self.timelabel_dict = dict() | ||
| #self.timelabel_dict = dict() |
There was a problem hiding this comment.
A few comments in this function need to be cleaned up.
| def main(): | ||
| """ | ||
| """ | ||
| #run_avhrr() |
There was a problem hiding this comment.
Are these comments used to run different plot types? If so, can you please document that at the top of main, or make it a CLI argument to swap between plot types?
| else: | ||
| title_str1 = "]" | ||
|
|
||
| #fig.suptitle(f"{title_str0}{title_str1}") |
There was a problem hiding this comment.
There are a few comments in this function that should be cleaned up.
KevinCounts
left a comment
KevinCounts
left a comment
There was a problem hiding this comment.
I've added comments to a few spots where comments should be cleaned up and main functions that need some documentation. I know one of those scripts is legacy. Other than those, I think this is looking great.
3 participants
Support for GSI stats radiance monitoring figures and minor updates to replay file count and increment plots.
GSIstats figures:
Replay figure updates:
Also includes new matplotlib style sheets for better web appearance
Example figures available at https://psl.noaa.gov/UFS/