Skip to content

Calibration hf v2 2#863

Open
shorvath-noaa wants to merge 2 commits into
NOAA-OWP:masterfrom
shorvath-noaa:calibration_hf_v2_2
Open

Calibration hf v2 2#863
shorvath-noaa wants to merge 2 commits into
NOAA-OWP:masterfrom
shorvath-noaa:calibration_hf_v2_2

Conversation

@shorvath-noaa

Copy link
Copy Markdown
Collaborator

Minor updates to run on Hydrofabric v2.2 and perform some t-route calibration test runs.

Additions

  • Read data tables stored within hydrofabric v2.2 correctly (handle duplicate columns in "flowpaths" and "flowpath-attributes tables"). Note: These updates enable performing MC-only runs on hydrofabric v2.2.
  • Added the capability to read forcings (q_lateral) from "*.CATOUT.csv" type files. These files are pre-processed from the standard "cat-*" files produced by ngen (converted units by catchment area).

Removals

Changes

Testing

Screenshots

Notes

  • Some of these updates were simply copied from @aaraney fork/branch here.

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@aaraney

aaraney commented Nov 28, 2025

Copy link
Copy Markdown
Member

For history sake, parts of this are duplicates of #851 and #853.

@JoshCu

JoshCu commented May 6, 2026

Copy link
Copy Markdown
Contributor

not sure if it's useful here but possibly relevant? I can make a pr if it would be useful
this lets t-route read directly from the cat csv files without needing preprocessing
CIROH-UA@33ca033
and here we fixed it to use the qlat_file_value_col instead of hardcoding Q_OUT 🤦
CIROH-UA@3e47c50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants