Skip to content

Clean-up variable initialization - #47

Open
drakest123 wants to merge 2 commits into
NOAA-OWP:masterfrom
drakest123:master
Open

Clean-up variable initialization#47
drakest123 wants to merge 2 commits into
NOAA-OWP:masterfrom
drakest123:master

Conversation

@drakest123

Copy link
Copy Markdown
Contributor

Some variables are initialized when they are declared. Depending on the compiler, these variables may not be properly initialized on subsequent invocations.

Additions

Initialized variables in the subroutine body. Changed variables to parameters if they do not change.

Removals

Removed variable initializations from the lines that declares them.

Testing

  1. Tested on a PC running standalone version of Snow-17.

Screenshots

Notes

Changes based on notes in Issue #44

@andywood andywood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine and correct the declaration/assignment issue with the previous coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants