NGWPC NWM Regionalization, Hindcast, and Coastal Tools 2026-06-09#63
Open
cmaynard-ngwpc wants to merge 82 commits into
Open
NGWPC NWM Regionalization, Hindcast, and Coastal Tools 2026-06-09#63cmaynard-ngwpc wants to merge 82 commits into
cmaynard-ngwpc wants to merge 82 commits into
Conversation
NGWPC-4425 add logging to LASAM module See merge request NGWPC/nwm-ngen/lgar-c!1
missed to commit Logger.cpp/hpp See merge request NGWPC/nwm-ngen/lgar-c!2
converted printfs, which on the first cut went under radar, into DEBUG level logs and some logging optimizations See merge request NGWPC/nwm-ngen/lgar-c!3
Add version.txt file See merge request NGWPC/nwm-ngen/lgar-c!4
Add version.txt file to release-candidate branch See merge request NGWPC/nwm-ngen/lgar-c!5
Release candidate Branch Merge to main for Release 1.0.0 See merge request NGWPC/nwm-ngen/lgar-c!6
Release 0.0.0 udpate version file See merge request NGWPC/nwm-ngen/lgar-c!7
Release 1.0.0 Merge to development See merge request NGWPC/nwm-ngen/lgar-c!8
…nto DEBUG level logs" This reverts commit 8d90ca2.
NGWPC-4425 add logging to LASAM module See merge request NGWPC/nwm-ngen/lgar-c!1
Revert "converted printfs, which on the first cut went under radar, into DEBUG level logs" See merge request NGWPC/nwm-ngen/lgar-c!9
Added RTX licensing verbiage See merge request NGWPC/nwm-ngen/lgar-c!10
Fix for NGWPC-5545 plus Merge branch 'NGWPC-4425' into 'development' See merge request NGWPC/nwm-ngen/lgar-c!11
Merge development into release-candidate for release rc-1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!12
Merge update_version_file_rc-1.1.0 into release-candidate for release rc-1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!13
Merge release-candidate into development for release rc-1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!14
Merge release-candidate into master for release 1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!15
Add serialization methods for BmiLGAR See merge request NGWPC/nwm-ngen/lgar-c!29
This reverts merge request !29
Revert "Merge branch 'idt/bmi-serialization' into 'development'" See merge request NGWPC/nwm-ngen/lgar-c!31
State serialization for BMI See merge request NGWPC/nwm-ngen/lgar-c!32
Convert assert calls to error logs (NGWPC-7474)
Merge release-candidate into development for release 3.1.1.3.0-rc2
Adapt serialization to revised protocol
Add NWM Ponded Depth (NGWPC-9175)
Merge development into ngwpc-candidate for release 3.1.2.1.0-rc1
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.1.0
* added precipitation_rate_out * corrected syntax error
Use nwm-ewts repository CPP library
* check for soil_type value * added logging before throwing runtime error * loglevel SEVERE -> FATAL
* updated groundwater_to_stream_recharge unit * added new output variable groundwater_to_stream_recharge_m3_per_s * fixed missed updates * fixed missed updates * Initialize bmi_unit_conv.catchment_area_m2 = 0.0
Merge development into ngwpc-candidate for release 3.1.2.2.0-rc1
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the model to use the nwm-ewts logging library and introduced a module-specific logging definition rather than relying on a generic EWTS implementation. Enhanced model functionality by adding precipitation rate output and implementing reset-time messaging support. Improved serialization by adding size headers to serialized data. Corrected and validated several model parameters, including updates to groundwater-to-stream recharge units, maximum soil type handling, and soil type value validation to improve model consistency and robustness.
Additions
Changes