Skip to content

NGWPC NWM Regionalization, Hindcast, and Coastal Tools 2026-06-09#63

Open
cmaynard-ngwpc wants to merge 82 commits into
NOAA-OWP:masterfrom
NGWPC:ngwpc-3.1.2.2.0
Open

NGWPC NWM Regionalization, Hindcast, and Coastal Tools 2026-06-09#63
cmaynard-ngwpc wants to merge 82 commits into
NOAA-OWP:masterfrom
NGWPC:ngwpc-3.1.2.2.0

Conversation

@cmaynard-ngwpc

Copy link
Copy Markdown

Updated the model to use the nwm-ewts logging library and introduced a module-specific logging definition rather than relying on a generic EWTS implementation. Enhanced model functionality by adding precipitation rate output and implementing reset-time messaging support. Improved serialization by adding size headers to serialized data. Corrected and validated several model parameters, including updates to groundwater-to-stream recharge units, maximum soil type handling, and soil type value validation to improve model consistency and robustness.

Additions

  • Integrated EWTS logging support across affected components, including module-specific logging updates, optional logging behavior, Docker/build integration, and unit-test coverage where applicable.
  • Added state saving, state restoration, reset-time, restart, and hindcast workflow capabilities, including related time-management updates and model restart handling.
  • Implemented and expanded serialization support, including serialized size metadata, message constants, integer-based transfer structures, deserialization bounds handling, and state-transfer messaging.

Changes

  • Corrected unit conversions and size/type reporting across model calculations, serialized buffers, time-step handling, and BMI-facing data exchanges.
  • Updated hydrologic model outputs and model-specific runtime behavior, including formulation outputs, GIUH/channel-inflow values, ponded-depth variables, and model-specific state/runtime handling.
  • Updated CI/CD, security scanning, downstream pipeline triggers, and customer-delivery workflow configuration.
  • Reworked serialization behavior, message metadata, reported state types, size calculations, buffer validation, and transfer logic for state save and restore workflows.
  • Updated additional release updates covering updates to max soil type number () and check for soil_type value ().

ngwpcareg and others added 30 commits November 18, 2024 20:14
NGWPC-4425 add logging to LASAM module

See merge request NGWPC/nwm-ngen/lgar-c!1
missed to commit Logger.cpp/hpp

See merge request NGWPC/nwm-ngen/lgar-c!2
converted printfs, which on the first cut went under radar, into DEBUG level logs and some logging optimizations

See merge request NGWPC/nwm-ngen/lgar-c!3
Add version.txt file

See merge request NGWPC/nwm-ngen/lgar-c!4
Add version.txt file to release-candidate branch

See merge request NGWPC/nwm-ngen/lgar-c!5
Release candidate Branch Merge to main for Release 1.0.0

See merge request NGWPC/nwm-ngen/lgar-c!6
Release 0.0.0 udpate version file

See merge request NGWPC/nwm-ngen/lgar-c!7
Release 1.0.0 Merge to development

See merge request NGWPC/nwm-ngen/lgar-c!8
This reverts commit ecafc03, reversing
changes made to f4d2726.
This reverts commit f4d2726, reversing
changes made to fe0f224.
NGWPC-4425 add logging to LASAM module

See merge request NGWPC/nwm-ngen/lgar-c!1
Revert "converted printfs, which on the first cut went under radar, into DEBUG level logs"

See merge request NGWPC/nwm-ngen/lgar-c!9
Added RTX licensing verbiage

See merge request NGWPC/nwm-ngen/lgar-c!10
Fix for NGWPC-5545 plus Merge branch 'NGWPC-4425' into 'development'

See merge request NGWPC/nwm-ngen/lgar-c!11
Merge development into release-candidate for release rc-1.1.0

See merge request NGWPC/nwm-ngen/lgar-c!12
Merge update_version_file_rc-1.1.0 into release-candidate for release rc-1.1.0

See merge request NGWPC/nwm-ngen/lgar-c!13
Merge release-candidate into development for release rc-1.1.0

See merge request NGWPC/nwm-ngen/lgar-c!14
Merge release-candidate into master for release 1.1.0

See merge request NGWPC/nwm-ngen/lgar-c!15
idtodd and others added 30 commits July 31, 2025 13:59
Add serialization methods for BmiLGAR

See merge request NGWPC/nwm-ngen/lgar-c!29
Revert "Merge branch 'idt/bmi-serialization' into 'development'"

See merge request NGWPC/nwm-ngen/lgar-c!31
State serialization for BMI

See merge request NGWPC/nwm-ngen/lgar-c!32
Convert assert calls to error logs (NGWPC-7474)
Merge release-candidate into development for release 3.1.1.3.0-rc2
Adapt serialization to revised protocol
Add NWM Ponded Depth (NGWPC-9175)
Merge development into ngwpc-candidate for release 3.1.2.1.0-rc1
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.1.0
* added precipitation_rate_out

* corrected syntax error
Use nwm-ewts repository CPP library
* check for soil_type value

* added logging before throwing runtime error

* loglevel SEVERE -> FATAL
* updated groundwater_to_stream_recharge unit

* added new output variable groundwater_to_stream_recharge_m3_per_s

* fixed missed updates

* fixed missed updates

* Initialize bmi_unit_conv.catchment_area_m2 = 0.0
Merge development into ngwpc-candidate for release 3.1.2.2.0-rc1
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants