Skip to content

adding dual reservoir calibratable parameters#60

Open
peterlafollette wants to merge 2 commits into
NOAA-OWP:masterfrom
peterlafollette:PTL_add_dual_res_to_calib
Open

adding dual reservoir calibratable parameters#60
peterlafollette wants to merge 2 commits into
NOAA-OWP:masterfrom
peterlafollette:PTL_add_dual_res_to_calib

Conversation

@peterlafollette

@peterlafollette peterlafollette commented May 11, 2026

Copy link
Copy Markdown
Contributor

Adds the capacity to calibrate dual reservoir parameters. Preliminary testing indicates that including the second reservoir only improves calibration in a handful of basins compared to CASAM with one reservoir, and might lead to more equifinality problems via more calibrated parameters. Nonetheless, including the second reservoir is not mandatory, and it can probably improve the model in some catchments.

Also adding residual water content as a calibratable parameter for soil layers 1 and 2, as well as effective saturated water content for layer 2.

Additions

-a_slow, b_slow, and frac_slow, smcmax_2, smcmin_1, smcmin_2 now in calibratable parameters list

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant