Skip to content

fixed ponded head mass balance accounting error for when conceptual r… #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterlafollette merged 1 commit into from
Jun 14, 2026
Merged

fixed ponded head mass balance accounting error for when conceptual r… #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bmi_lgar.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ Update()
state->state_previous = listCopy(state->head);

double ponded_flux_for_CR = 0.0;
double volon_start_subtimestep_cm = volon_timestep_cm;

// allocates some water to conceptual reservoir storage via conditional preferential flow
if (state->lgar_bmi_params.runoff_in_prev_step){
Expand Down Expand Up @@ -742,7 +743,7 @@ Update()
/*----------------------------------------------------------------------*/
// mass balance at the subtimestep (local mass balance)

double local_mb = volstart_subtimestep_cm + precip_subtimestep_cm + volon_timestep_cm - volrunoff_subtimestep_cm - volQ_CR_subtimestep_cm - volCRend_subtimestep_cm + volCRstart_subtimestep_cm
double local_mb = volstart_subtimestep_cm + precip_subtimestep_cm + volon_start_subtimestep_cm - volrunoff_subtimestep_cm - volQ_CR_subtimestep_cm - volCRend_subtimestep_cm + volCRstart_subtimestep_cm
- AET_subtimestep_cm - volon_subtimestep_cm - volrech_subtimestep_cm - interflow_subtimestep_cm - volend_subtimestep_cm;


Expand Down
Loading