Update mechanism for determining forecast dataset format#107
Merged
maddenp-cu merged 15 commits intoNOAA-GSL:mainfrom Feb 20, 2026
Merged
Update mechanism for determining forecast dataset format#107maddenp-cu merged 15 commits intoNOAA-GSL:mainfrom
maddenp-cu merged 15 commits intoNOAA-GSL:mainfrom
Conversation
elcarpenterNOAA
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An apparently valid HRRRCast GRIB file was seen recently that
wxvxcould not classify as GRIB. The method used by thepython-magiclibrary uses the same file signature (aka "magic") technique as the standard Unix utilityfile, andfilemakes the same mistake: Compare its view of one GRIB fileto that of the HRRRCast GRIB file in question:
My guess is that
filegets a hit on theDOS/MBRsignature first and accepts that, even though the GRIB signature would have matched, too.As far as I can tell, the HRRRCast GRIB file is valid: ecCodes'
grib_dumpandgrib_lsreport no errors processing it.This PR replaces the
python-magicmechanism with one that classifies forecast datasets by trying to open them with thezarrandnetCDF4libraries first, then inspecting the initial bytes in the file to see if it is apparently GRIB.wxvxdoesn't need the generality ofpython-magicsince it only supports three forecast-dataset formats. The updated code classifies the troublesome HRRRCast GRIB file correctly, as well as a handful of real-world netCDF and Zarr datasets.As an optimization and as a safety override, a new config key is also provided to suppress automatic classification: If the user sets
forecast.formattogrib,netcdf, orzarr,wxvxwill accept that designation and do no checks.