Open
Conversation
Contributor
|
Thanks.
…On Tue, Aug 20, 2024 at 1:13 PM Geary Layne ***@***.***> wrote:
Linear Issue
IDSSE-xxx <https://linear.app/idss/issue/IDSSE-xxx>
Changes
I created this PR as a way to share the code, probably best to not merge
this branch.
- This branch includes at least some of the code I used to validate
the Temperature field.
- The test_temp_data() "new code" creates the image and gets values.
- I can't find the code that I used to validate the other variables.
- Let me know if you need help understanding this code.
Explanation
N/A
------------------------------
You can view, comment on, or merge this pull request online at:
#72
Commit Summary
- 80b66b6
<80b66b6>
current status
- e1f943c
<e1f943c>
with test function for validating NBM temp
File Changes
(1 file <https://github.com/NOAA-GSL/idss-engine-commons/pull/72/files>)
- *M* python/idsse_common/test/test_geo_image.py
<https://github.com/NOAA-GSL/idss-engine-commons/pull/72/files#diff-226c86a3fa6b91d9a7819f14a405d6ebe96b65574c600f0095309c06190a16b0>
(88)
Patch Links:
- https://github.com/NOAA-GSL/idss-engine-commons/pull/72.patch
- https://github.com/NOAA-GSL/idss-engine-commons/pull/72.diff
—
Reply to this email directly, view it on GitHub
<#72>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATO5PJNNJN33CD7XYQA7SALZSOIPBAVCNFSM6AAAAABM2Q5B62VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3TMMZWGAYDGNQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Paul Hamer
<http://www.esrl.noaa.gov/fiqas/>
Global Systems Laboratory (GSL)
325 Broadway R/GS5
Boulder, CO 80305-3328
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Issue
IDSSE-xxx
Changes
I created this PR as a way to share the code, probably best to not merge this branch.
Explanation
N/A