-
Notifications
You must be signed in to change notification settings - Fork 27
fully integrated physics #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vithikashah001
merged 52 commits into
NOAA-GFDL:main
from
linjiongzhou:user/lnz/shield2025_inline_final_unverified
Jan 15, 2026
Merged
fully integrated physics #68
vithikashah001
merged 52 commits into
NOAA-GFDL:main
from
linjiongzhou:user/lnz/shield2025_inline_final_unverified
Jan 15, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during the initialization.
…o the physics during the initialization.
…physics during the initialization.
… user/lnz/shield2023_inline
…ongzhou/atmos_drivers into user/lnz/shield2025_inline
Member
|
@linjiongzhou Who from the FV3 team do you think should review this PR? |
Contributor
Author
Both @lharris4 and @gaokun227 can review this PR. |
gaokun227
approved these changes
Jan 7, 2026
lharris4
approved these changes
Jan 9, 2026
laurenchilutti
approved these changes
Jan 15, 2026
vithikashah001
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on the latest main branch and includes the fully integrated physics framework developed since the start of this effort. When running with the original physics configuration, results should remain unchanged.
To enable the integrated physics, add the following namelist:
&integ_phys_nml
do_fast_phys = .T.
do_inline_pbl = .T.
do_inline_cnv = .T.
do_inline_gwd = .T.
inline_cnv_flag = 2
inline_pbl_flag = 1
&sa_sas_nml
/
&sa_aamf_nml
/
&sa_tke_edmf_nml
/
&sa_tke_edmf_new_nml
/
&sa_gwd_nml
/
Fixes # (issue)
How Has This Been Tested?
This functionality has been exercised extensively throughout the development process. However, this final version has not yet been re-tested after merging the latest updates from main.
Checklist: