Adjust precipitation rate calculations for units #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephMouallem
requested review from
laurenchilutti,
thomas-robinson and
uramirez8707
as code owners
Contributor
Author
laurenchilutti
approved these changes
Dec 9, 2025
| ! --- precip rate (kg/m**2/s) | ||
| if ( IPD_Data(nb)%Sfcprop%srflag(ix) .lt. 0.5) then ! rain (srflag = 0) | ||
| Atmos%lprec(i,j) = 1./IPD_Control%dtp * IPD_Data(nb)%Sfcprop%tprcp(ix) | ||
| Atmos%lprec(i,j) = 1./IPD_Control%dtp * IPD_Data(nb)%Sfcprop%tprcp(ix) * 1000. |
Member
There was a problem hiding this comment.
You should document the units of sfcprop tpcrp at https://github.com/NOAA-GFDL/SHiELD_physics/blob/8e8bc38157b4a8fc5c2b1d479d5f09c47222dae3/GFS_layer/GFS_typedefs.F90#L252
gaokun227
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPD_Data(nb)%Sfcprop%tprcp(ix)is inmor (kg/m^2 * 1e-3).We add
*1000to convert it tokg/m^2.The final fields passed to the coupler,
Atmos%lprecandAtmos%fprec, are inkg/m^2/sas expected by the land and ocean models.NOTE: although some comments in the model suggest these field represent the accumulated rain quantity per time-step, they in fact represent the precipitation rate.