Fix unit scaling in SIS_sponge #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the unit scaling factor for reading the sponge relaxation rate to US%T_to_s as is appropriate for a rate. An incorrect but consistent compensating factor was removed from the expression for max_rlxrate, and the line unscaling dt_slow into a new variable was also removed. There are some other minor changes included in this commit. The unused variables I_Nk, coeff, Idt_slow, ice_salin, iconc_old, ithk_old, mask_in and 6 others were removed from apply_isponge and a three-line expression setting the limited fractional open water category was consolidated down to a single line. The missing rescaling factor for the initial value of tfi was added and the initial value of sice was change to 0; neither of these initial values appear to be used. In addition comments describing the units of 23 real variables were added in SIS_sponge.F90. All answers are bitwise identical when no dimensional rescaling is applied, but more of the code is now working with rescaled variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the unit scaling factor for reading the sponge relaxation rate to
US%T_to_sas is appropriate for a rate. An incorrect but consistent compensating factor was removed from the expression formax_rlxrate, and the line unscalingdt_slowinto a new variable was also removed.There are some other minor changes included in this commit. The unused variables
I_Nk,coeff,Idt_slow,ice_salin,iconc_old,ithk_old,mask_inand 6 others were removed fromapply_isponge()and a three-line expression setting the limited fractional open water category was consolidated down to a single line. The missing rescaling factor for the initial value oftfiwas added and the initial value ofsicewas change to 0; neither of these initial values appear to be used. In addition comments describing the units of 23 real variables were added in SIS_sponge.F90.All answers are bitwise identical when no dimensional rescaling is applied, but more of the code is now working with rescaled variables.