+Fix dimensional rescaling of DT_ICE_DYNAMICS #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the missing dimensional rescaling factor for DT_ICE_DYNAMICS in SIS_tracer_advect_init(). This commit could change answers in some case when dimensional rescaling of time is being tested in SIS2, but because this particular timestep is only used to determine the maximum number of iterations for the advection of ice thicknesses and tracers, and the maximum number of iterations is always at least 1, this appears to have gone undetected heretofore in the short tests with small CFL numbers that we have used for dimensional consistency testing in SIS2. This change includes adding a new unit_scale_type argument to this same routine. All answers are bitwise identical when T_RESCALE_POWER is 0 in SIS_input (as is always the case in production runs), but there is a new argument to a publicly visible interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing dimensional rescaling factor for
DT_ICE_DYNAMICSinSIS_tracer_advect_init(). This commit could change answers in some case when dimensional rescaling of time is being tested in SIS2, but because this particular timestep is only used to determine the maximum number of iterations for the advection of ice thicknesses and tracers, and the maximum number of iterations is always at least 1, this appears to have gone undetected heretofore in the short tests with small CFL numbers that we have used for dimensional consistency testing in SIS2. This change includes adding a newunit_scale_typeargument to this same routine. All answers are bitwise identical whenT_RESCALE_POWERis 0 in SIS_input (as is always the case in production runs), but there is a new argument to a publicly visible interface.