*Correct metadata or calculation of 19 diagnostics #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
force-pushed
the
fix_diagnostics
branch
from
f09ed12 to
4592e7c
Compare
Corrected the longname, unit description, conversion factor or the calculation of 19 diagnostics in 4 files. In two cases, the calculations were revised to avoid array syntax calculation of whole arrays, including potentially uninitialized halo regions. In the case of two other diagnostics, necessary unit conversion factors were missing altogether. In yet other cases, the unit conversion factors were moved into the register_SIS_diagnostics conversion factors to facilitate comparison with the declared units. A total of 34 now unnecessary missing_value arguments to related calls to register_SIS_diag_field() were also removed. All solutions are bitwise identical, but the metadata associated with some diagnostics have been changed, and some diagnostics that previously were not passing unit testing are passing now.
Hallberg-NOAA
force-pushed
the
fix_diagnostics
branch
from
4592e7c to
86ab376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the longname, unit description, conversion factor or the calculation of 19 diagnostics in 4 files. In two cases, the calculations were revised to avoid array syntax calculation of whole arrays, including potentially uninitialized halo regions. In the case of two other diagnostics, necessary unit conversion factors were missing altogether. In yet other cases, the unit conversion factors were moved into the
register_SIS_diagnostics()conversion factors to facilitate comparison with the declared units. All solutions are bitwise identical, but the metadata associated with some diagnostics have been changed, and some diagnostics that previously were not passing unit testing are passing now.