Set range and units for 19 nondimensional diagnostics #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
force-pushed
the
nondim_diagnostic_ranges
branch
from
222bd98 to
105cab0
Compare
Set range and corrected the units for 19 nondimensional diagnostics and explicitly named the units arguments in these calls. Also changed the descriptions of the range arguments to routines in SIS_diag_mediator to no longer state that these arguments are unused in SIS2. A total of 20 now unnecessary missing_value arguments to related calls to register_SIS_diag_field() were also removed. All answers are bitwise identical, but there are metadata changes in some diagnostic files,
Hallberg-NOAA
force-pushed
the
nondim_diagnostic_ranges
branch
from
105cab0 to
e182fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set range and corrected the units for 19 nondimensional diagnostics and explicitly named the units arguments in these calls. Also changed the descriptions of the range arguments to routines in
SIS_diag_mediator.F90to no longer state that these arguments are unused in SIS2. All answers are bitwise identical, but there are metadata changes in some diagnostic files,