Fix syntax in 84 unit descriptions #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
force-pushed
the
fix_84_unit_descriptions
branch
from
19f31c3 to
5a6a04a
Compare
Corrected the syntax of 83 unit descriptions used in diagnostic registrations in 7 files and explicitly name the units arguments in 107 calls to register_SIS_diag_field(), and removed the now unnecessary missing_value arguments in these 107 calls. Also added a missing unit argument to one call to register_restart_field(). All answers are bitwise identical, but there are metadata changes in some diagnostic and restart files.
Hallberg-NOAA
force-pushed
the
fix_84_unit_descriptions
branch
from
5a6a04a to
d6da476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the syntax of 83 unit descriptions used in diagnostic registrations in 7 files and explicitly name the units arguments in 101 calls to
register_SIS_diag_field(). Also added a missing unit argument to one call toregister_restart_field(). All answers are bitwise identical, but there are metadata changes in some diagnostic and restart files.