Use rescaling to or from Pa with single factor #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
force-pushed
the
simpler_rescaling_to_Pa
branch
from
6b6b1f0 to
bda2df8
Compare
Use the rescaling combinations US%RLZ_T2_to_Pa, US%Pa_to_RL2_T2, US%Pa_to_RLZ_T2 and US%L_T2_to_m_s2 in 111 places in 7 files for greater clarity of purpose and fewer calculations. Also changed to explicitly name the units arguments to register_SIS_diag_field() to aid in consistency testing and removed the now unnecessary missing_value arguments in these 41 calls. All answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
simpler_rescaling_to_Pa
branch
from
bda2df8 to
3fe7bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the rescaling combinations
US%RLZ_T2_to_Pa,US%Pa_to_RL2_T2,US%Pa_to_RLZ_T2andUS%L_T2_to_m_s2in 111 places in 7 files for greater clarity of purpose and fewer calculations. Also changed to explicitly name the units arguments toregister_SIS_diag_field()in 41 of these to aid in consistency testing. All answers are bitwise identical.