Skip to content

WIP: re-enable mypy for pySHiELD #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
romanc wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

WIP: re-enable mypy for pySHiELD #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dace072
fix type issues surfaced from pace integration
romanc Jan 13, 2026
25e7ae4
not a typo in pyrte, but with out code
romanc Jan 14, 2026
6fd7f10
WIP: re-enable mypy in pySHiELD package
romanc Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ repos:
- id: mypy
name: mypy-physics
args: ["--config-file", "pyproject.toml"]
files: pySHiELD
Copy link
Collaborator Author

@romanc romanc Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why mypy never complained because that's a case-sensitive file filter that wasn't updated when the source directory was renamed from pySHiELD to pyshield.

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
hooks:
Expand Down
2 changes: 1 addition & 1 deletion examples/notebook/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def states_from_fortran_restarts(
tracer_datafile: Path,
ak: Quantity,
quantity_factory: QuantityFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
dycore_data = xr.open_dataset(dycore_datafile)
phys_data = xr.open_dataset(phys_datafile)
Expand Down
8 changes: 7 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,20 @@ sections = "FUTURE,STDLIB,THIRDPARTY,FIRSTPARTY,LOCALFOLDER"
use_parentheses = true

[tool.mypy]
exclude = ["tests/conftest.py"]
explicit_package_bases = true
follow_imports = "normal"
ignore_missing_imports = true
namespace_packages = true
strict_optional = false
warn_unreachable = true

[[tool.mypy.overrides]]
ignore_errors = true
module = [
# We currently can't type tracers correctly
"pyshield.stencils.*"
]

[tool.setuptools]
include-package-data = true

Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def states_from_fortran_restarts(
quantity_factory: QuantityFactory,
qf_sfc: QuantityFactory,
stencil_factory: StencilFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
pk0inv = (1.0 / physcons.P00) ** constants.KAPPA
dycore_data = xr.open_dataset(dycore_datafile)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_gfdl_cld_mp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def states_from_fortran_restarts(
ak: Quantity,
quantity_factory: QuantityFactory,
stencil_factory: StencilFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
pk0inv = (1.0 / physcons.P00) ** constants.KAPPA
dycore_data = xr.open_dataset(dycore_datafile)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_gfs_mp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def states_from_fortran_restarts(
ak: Quantity,
quantity_factory: QuantityFactory,
stencil_factory: StencilFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
pk0inv = (1.0 / physcons.P00) ** constants.KAPPA
dycore_data = xr.open_dataset(dycore_datafile)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_radiation_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def states_from_fortran_restarts(
tracer_datafile: Path,
ak: Quantity,
quantity_factory: QuantityFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
dycore_data = xr.open_dataset(dycore_datafile)
phys_data = xr.open_dataset(phys_datafile)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_samfshalconv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def states_from_fortran_restarts(
ak: Quantity,
quantity_factory: QuantityFactory,
stencil_factory: StencilFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
pk0inv = (1.0 / physcons.P00) ** constants.KAPPA
dycore_data = xr.open_dataset(dycore_datafile)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_satmedmf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def states_from_fortran_restarts(
ak: Quantity,
quantity_factory: QuantityFactory,
stencil_factory: StencilFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
pk0inv = (1.0 / physcons.P00) ** constants.KAPPA
dycore_data = xr.open_dataset(dycore_datafile)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_sfc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def states_from_fortran_restarts(
quantity_factory: QuantityFactory,
qf_sfc: QuantityFactory,
stencil_factory: StencilFactory,
schemes: PHYSICS_PACKAGES,
schemes: list[PHYSICS_PACKAGES],
):
pk0inv = (1.0 / physcons.P00) ** constants.KAPPA
dycore_data = xr.open_dataset(dycore_datafile)
Expand Down
Loading