Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Jan 21, 2026

Description

This PR pins pyFV3 to NDSL version 2026.01.00 (as discussed in the last NASA/NOAA NDSL sync) and updates code to remove any deprecation warnings.

How Has This Been Tested?

All good as long as CI is still green.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

This PR pins pyFV3 to NDSL version 2026.01.00 and updates code to remove
any deprecations warnings.
@romanc romanc requested review from jjuyeonkim and twicki January 21, 2026 09:50
@romanc
Copy link
Collaborator Author

romanc commented Jan 21, 2026

Ah apparently, we need to update pace first such that the CI hook of pace is happy with the changes here (pace still fetches the last version of NDSL).

@romanc romanc marked this pull request as draft January 21, 2026 10:34
@romanc romanc marked this pull request as ready for review January 21, 2026 13:35
@romanc romanc requested review from jjuyeonkim and twicki January 21, 2026 13:35
Copy link
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's go!

@jjuyeonkim jjuyeonkim added this pull request to the merge queue Jan 21, 2026
Merged via the queue into NOAA-GFDL:develop with commit 64ddc3a Jan 21, 2026
5 of 6 checks passed
@romanc romanc deleted the romanc/ndsl-2026.01.00 branch January 21, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants