Skip to content

refactor: use new constructor of QuantityFactory #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanc wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: use new constructor of QuantityFactory #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/notebook/test_functionality.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
")\n",
"\n",
"# useful for easily allocating distributed data storages (fields)\n",
"quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)\n",
"quantity_factory = QuantityFactory(sizer=sizer, backend=backend)\n",
"\n",
"compilation_config = CompilationConfig(backend=backend, communicator=cs_communicator)\n",
"\n",
Expand Down
2 changes: 1 addition & 1 deletion pyfv3/wrappers/geos_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def __init__(
sizer = SubtileGridSizer.from_namelist(
self.namelist, partitioner.tile, self.communicator.tile.rank
)
quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)
quantity_factory = QuantityFactory(sizer=sizer, backend=backend)

# set up the metric terms and grid data
metric_terms = MetricTerms(
Expand Down
2 changes: 1 addition & 1 deletion tests/mpi/test_doubly_periodic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_dycore_runs_one_step() -> None:
grid_indexing = GridIndexing.from_sizer_and_communicator(
sizer=sizer, comm=communicator
)
quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)
quantity_factory = QuantityFactory(sizer=sizer, backend=backend)
metric_terms = MetricTerms(
quantity_factory=quantity_factory,
communicator=communicator,
Expand Down
5 changes: 1 addition & 4 deletions tests/savepoint/translate/translate_init_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,9 @@ def compute_parallel(self, inputs, communicator):
tile_rank=communicator.tile.rank,
)

quantity_factory = QuantityFactory.from_backend(
sizer, backend=self.stencil_factory.backend
)
quantity_factory = QuantityFactory(sizer, backend=self.stencil_factory.backend)

grid_data = GridData.new_from_metric_terms(metric_terms)
quantity_factory = QuantityFactory()

state = analytic_init.init_analytic_state(
analytic_init_case="baroclinic",
Expand Down