Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Jan 19, 2026

Description

The pre-release checklist highlighted a typing issue in python_extension.py where a while condition wouldn't use is (not) None and thus mypy couldn't safely derive the type and thus the last return was deemed unreachable code (which isn't true). This is a quick PR to improve the types such that mypy is happy.

How has this been tested?

Tested locally and as part of NOAA-GFDL/pace#175 (which is currently pointing NDSL to this branch).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/): N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Jan 19, 2026
Merged via the queue into NOAA-GFDL:develop with commit 1ca8019 Jan 19, 2026
6 checks passed
@romanc romanc deleted the romanc/types-is-not-none branch January 19, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants