refactor: improve types in python extension #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pre-release checklist highlighted a typing issue in
python_extension.pywhere awhilecondition wouldn't useis (not) Noneand thusmypycouldn't safely derive the type and thus the last return was deemed unreachable code (which isn't true). This is a quick PR to improve the types such thatmypyis happy.How has this been tested?
Tested locally and as part of NOAA-GFDL/pace#175 (which is currently pointing NDSL to this branch).
Checklist