Inline harmonic analysis #999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving HA_accum for SSH into the n-loop, so that harmonic analysis is performed on the instantaneous SSH instead of the time-averaged SSH after the n-loop.
Hallberg-NOAA
requested changes
Dec 27, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I think that there should be a new runtime parameter to switch between the two options of when to call HA_accum because this commit will change answers and it is possible that the previous solutions are already in use. Also, it may be slightly less expensive to do the harmonic analysis less frequently, although I do not think that the difference in CPU time will be significant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving HA_accum for SSH into the n-loop, so that harmonic analysis is performed on the instantaneous SSH instead of the time-averaged SSH after the n-loop. My test case does not show any noticeable difference but I think this would make the harmonic analysis more accurate if relatively larger time steps are used.