Added the MEKE_POSITIVE parameter to enforce MEKE to be positive #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit added a new parameter MEKE_POSITIVE to deal with the issue that MEKE becomes negative. If MEKE_POSITIVE is True (default is False), all negative values of MEKE will be set to zero. This operation will break the conservation of MEKE so should be used carefully. The motivation to add this parameter is that we found the MEKE simulation became unstable in the global coupled experiment of ESM4.5. The instability was caused by the negative values at a few shallow regions (depth smaller than 10 m). These negative values quickly spread into the open ocean and made MEKE negative over the whole ocean. By using MEKE_POSITIVE to clip out negative values, the source of instability was removed and the simulation seemed to be sensible. Although this method violates the MEKE conservation, negative values seemed to mainly happen at a few shallow regions, which may not cause a big error to the global MEKE conservation.
The best solution for this issue would be to fix the bug that causes negative values in the MEKE module. There are a few terms, such as MEKE%mom_src and MEKE%GM_src, that are not positive definite. Fixing these may resolve the negative MEKE issue, but I have not had a success yet.