Add merged Coriolis arrays in MOM_barotropic #868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the 8 Coriolis parameter arrays (
[abcd]zonand[abcd]mer) with merged 3-dimensional arrays (f_4_uandf_4_v), where the extra dimension is of size 4 and varies fastest. This reduces the number of arguments being passed around and it could improve performance by increasing the likelihood of cache hits. Also made thedgeo_deargument toset_up_BT_OBC()non-optional, which reduces the number of calls to this routine and should increase the chances it might be inlined. A few more spelling errors were corrected, and some notes added in comments highlighting potentially suspect reassignments of effective total gravities at open boundary condition points. All answers are bitwise identical and no external interfaces are changed.