*Test before using frazil for ice-shelf water flux #1012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test to only apply frazil at the base of an ice shelf if the frazil array is allocated, thereby avoiding a segmentation fault in cases that have and ice shelf but do not have the runtime parameter FRAZIL set to true. This bug was causing the ocean_only/ISOMIP test cases to fail, and fixing it allows them to work again, providing the same answers as previously. This bug was introduced on Dec. 2, 2025 as a part of PR mom-ocean#985 to dev/gfdl.
Member
Author
|
This bug is already being addressed as a part of PR #1009, so this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to only apply frazil at the base of an ice shelf if the
sfc_state%frazilarray is allocated, thereby avoiding a segmentation fault in cases that have and ice shelf but do not have the runtime parameterFRAZILset to true. This bug was causing the ocean_only/ISOMIP test cases to fail, and fixing it allows them to work again, providing the same answers as previously.This bug was introduced on Dec. 2, 2025 as a part of PR #985 to dev/gfdl.