+Add and use trim_trailing_commas() and ints_to_string() #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the function i2s from MOM_diag_mediator into the function ints_to_string in MOM_string_functions, and moved the code removing trailing commas from two places in MOM_diag_mediator into the new function trim_trailing_commas in MOM_string_functions. Because of the duplication of code between MOM6, SIS2 and the MOM6 ice shelf code, these functions would need to be replicated 3 or 6 times without these changes. Also added unit tests of both new functions to string_functions_unit_tests. All answers are bitwise identical but there are two new public functions in MOM_string_functions.
Call trim_trailing_commas from register_diag_field and register_static_field and ints_to_string from trim_trailing_commas and eliminated the now redundant routine i2s. All code functions exactly as before but there is less duplicative code.
Hallberg-NOAA
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of two commits first adds the new functions
ints_to_string()andtrim_trailing_commas()to MOM_string_functions, based on code that previously been in MOM_diag_mediator, and then in a second commit calls these functions from appropriate points in MOM_diag_mediator and eliminates the redundant code. All answers and output are bitwise identical, apart from three new tests reported on bystring_functions_unit_tests().