Delete unneeded masks args from 25 post_data calls #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant mask arguments from 25 post_data() calls for 2-d arrays that were using masks that would have been set anyway based on the axes of these diagnostics. Explicit masks are only required for arrays that use unusual masks, pass atypically sized arrays (e.g., just the computational domain), or are static diagnostics that do not evolve in time. All answers and diagnostic output are bitwise identical.
Hallberg-NOAA
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant
maskarguments from 25post_data()calls for 2-d arrays that were using masks that would have been set anyway based on the axes of these diagnostics. Explicit masks are only required for arrays that use unusual masks, pass atypically sized arrays (e.g., just the computational domain), or are static diagnostics that do not evolve in time. All answers and diagnostic output are bitwise identical.