Fix reference of unassociated pointer #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcroft
force-pushed
the
fix-ref-unassoc-ptr
branch
from
da2300b to
c79dd09
Compare
Hallberg-NOAA
approved these changes
Dec 23, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that these changes are correct and should prevent some uncommon problems. Although I am approving these changes, I would ask that parentheses be added in the future to avoid having to remember (or look up) the Fortran operator precedence rules to verify the correctness of expressions..
These two references to members of a pointer don't seem to be hit except under special circumstances but nevertheless I ran in to them when debugging an unrelated problem. There are two references to members of `diag%axes` that assume `diag%axes` are associated, but in the specific case I was debugging this was not the case.
Hallberg-NOAA
force-pushed
the
fix-ref-unassoc-ptr
branch
from
c79dd09 to
0d11a0d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #1005 +/- ##
=========================================
Coverage 37.57% 37.57%
=========================================
Files 307 307
Lines 93894 93894
Branches 18036 18036
=========================================
Hits 35280 35280
Misses 51976 51976
Partials 6638 6638 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/29654. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two references to members of
diag%axesthat assumediag%axesare associated, but in the specific case I was debugging this was not the case. These references were trapped when debugging but they don't seem to be hit except under special circumstances.