Explicitly define external directory of SIS2 #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The CIs above do not use the legacy mkmf builds, and I still don't understand how to properly test the MRS builds, so I can't say for sure if this will actually work. (👉 @adcroft) |
Member
Author
|
This is meant to fix a regression testing issue discovered by NOAA-GFDL/SIS2#225 |
Member
|
Update the Makefiles in ice_ocean_SIS2 and coupled_* too. |
The imminent introduction of the icebergs stub to SIS2, which is not used in our CI tests, can override the libicebergs.a symbols, causing the latter to never be used. This can change answers (among other things). The glob `external/*` mkmf pathing is replaced with `external/Icepack_interfaces`, so that any future icebergs stub will be ignored.
marshallward
force-pushed
the
sis2-explicit-externals
branch
from
0b40787 to
6ca0774
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6-examples/-/pipelines/29605. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imminent introduction of the icebergs stub to SIS2, which is not used in our CI tests, can override the libicebergs.a symbols, causing the latter to never be used. This can change answers (among other things).
The glob
external/*mkmf pathing is replaced withexternal/Icepack_interfaces, so that any future icebergs stub will be ignored.