-
Notifications
You must be signed in to change notification settings - Fork 45
Fix bad xgrid along zero longitude when LND grid not same as ATM #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix bad xgrid along zero longitude when LND grid not same as ATM #379
Conversation
- Address issue NOAA-GFDL#366 - When LND grid is not the same as ATM the xgrid is wrong along the Prime Meridian, E.g., if ATM is c96 and LND is c48, the xgrid cell areas are small by almost a factor of 2 along longitude=0 and the land mask has a spurious line along longitude=0 - The root cause is the Ocean grid is shifted right by 360 degree assuming that the land and atmos grids are the same which cause the atmXlnd exchange grid cells that are just to the left of the longitude=0 to be ignored. - The fix is to (re)apply the fixlon to shift Ocean grid based on the atmxlnd_x[l][0] rather than the atm_avg.
|
@ceblanton could you assign this to be reviewed (I don't seem to have permissions to do that). I suggest @mlee03 and @bensonr as reviewers. Thanks. |
|
@nikizadehgfdl I added you to the github team that can write to the FRE repositories. Can you check? |
bensonr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@nikizadehgfdl, could I request for the input and output files used to test this case? I want to make sure FMSgridtools/make_coupler_mosaic produces the correct xgrid |
|
@mlee03, the input files are in so, the fix can be tested with the following command line on PAN (an105): |
--land_mosaic#366Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses