Fregrid Optimization: Device Pointers #356
Conversation
- During exchange grid generation and remapping data, allocate temporary arrays on the device only -Allocate data memory on device using acc_malloc -Remove instances of `data create` – data will only be housed on device, so there is no need to match creation on host. - Modify `present` clause, removing data allocated memory using acc_malloc - Utilize deviceptr clause to declare that pointers in list refer to a device pointer that does not need to be allocated / moved between host and device.
|
@hderry, do you know which test is failing? |
It is running additional tests with -- make -C build -j check The same tests I mentioned failing in my initial comment about checklist FAIL: split_ncvars/split_ncvars-p |
2 participants
Description
During exchange grid generation and remapping data, allocate temporary arrays on the device.
- Allocate data memory on device using acc_malloc
-Remove instances of
data create– data will only be housed on device, so there is no need to match creation on host.Modify
presentclause, removing data allocated memory using acc_mallocUtilize deviceptr clause to declare that pointers in list refer to a device pointer that does not need to be allocated / moved between host and device.
How Has This Been Tested?
Checklist:
[✓] My code follows the style guidelines of this project
[✓ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[✓] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[ ] New check tests, if applicable, are included
[x ]
make distcheckpassessplit_ncvars/ fails but all other checks pass or are skipped