Skip to content

Conversation

@uramirez8707
Copy link
Contributor

Description
This PR fixes an issue when adding the cell_measures attribute. The code was not getting the output name of the area variable correctly.

!< If writing the varname can be the outname which is defined in the yaml
if (present(to_write)) then
if (to_write) then
!TODO this is wrong
rslt = this%diag_field(1)%get_var_outname()
endif
endif

Fixes #1814

How Has This Been Tested?
CI, including new test (which fails without this update)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

!< If writing the varname can be the outname which is defined in the yaml
if (present(to_write)) then
if (to_write) then
!TODO this is wrong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@vithikashah001 vithikashah001 merged commit 5ac9cfd into NOAA-GFDL:main Jan 8, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG - MODERN DIAG MANAGER cell measures attribute is not written correctly

3 participants