Skip to content

post release action for version number + fix docs trigger #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rem1776 merged 5 commits into from
Nov 8, 2022
Merged

post release action for version number + fix docs trigger #1055

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5b8b67
add initial action for automated version changes
Oct 13, 2022
fa77993
add action options
Oct 13, 2022
fa2a97e
fix release trigger running more than once
Oct 13, 2022
eb129d5
Add other reviewers to the list
rem1776 Oct 17, 2022
1540dea
remove reviewers
rem1776 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/update_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Generate and deploy documentation on GH pages

# update on releases or when triggered manually(must have write access)
on: [release, workflow_dispatch]

on:
release:
types: [published]
workflow_dispatch:
jobs:
update_docs:
runs-on: ubuntu-latest
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
on:
release:
types: [published]
jobs:
add-dev-to-version:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Append version with dev
run: sed -i '/20[0-9][0-9]\.[0-9][0-9]/ s/]/-dev]/' configure.ac
- name: Create pull request
uses: peter-evans/create-pull-request@v4
with:
base: main # creates a new branch off of main
branch: add-dev-post-release # name of the created branch
branch-suffix: timestamp # add a timestamp to branch name
delete-branch: true # delete afer merge
title: Append dev to version number post-release
body: automated change, adds '-dev' to the version number upon releases
reviewers: rem1776
Copy link
Member

@thomas-robinson thomas-robinson Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reviewers required? Will rem1776 be the only required reviewer? This could cause a potentially dangerous situation if you're on leave or away at the time of a release and a backup person is required.

Copy link
Contributor Author

@rem1776 rem1776 Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it adds the other reviewers based on codeowners like it does for other prs, but i mean it's always the same changes so i'll just add you and rusty to that list

Copy link
Member

@thomas-robinson thomas-robinson Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get rid of reviewers entirely? Then it should just add the 3 of us, right?

Copy link
Contributor Author

@rem1776 rem1776 Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works too