Skip to content

Remove some unused build options#498

Open
AlysonStahl-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
AlysonStahl-NOAA:as_build2
Open

Remove some unused build options#498
AlysonStahl-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
AlysonStahl-NOAA:as_build2

Conversation

@AlysonStahl-NOAA
Copy link
Collaborator

Part of #497

Removes:
USE_TIGGE
USE_MYSQL
USE_WMO_VALIDATION
DISABLE_TIMEZONE

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes four unused or always-available build options from wgrib2 as part of build system cleanup efforts (issue #497): USE_TIGGE, USE_MYSQL, USE_WMO_VALIDATION, and DISABLE_TIMEZONE.

Changes:

  • TIGGE functionality is now always available instead of being optional
  • MySQL support for the extra build is now auto-detected rather than manually configured
  • WMO_VALIDATION and DISABLE_TIMEZONE build options are removed from CMake configuration

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
wgrib2/wgrib2_meta.h.in Removes cmakedefine directives for USE_TIGGE, USE_MYSQL, USE_WMO_VALIDATION, and DISABLE_TIMEZONE
wgrib2/config.h.in Removes cmakedefine directives for the removed build options
wgrib2/init.c Removes USE_TIGGE conditional compilation guards around tigge variable declarations
wgrib2/gribtab.c Removes USE_TIGGE guards around tigge_gribtable definition, making it always available
wgrib2/cname.c Removes USE_TIGGE guards from getName_all function to make tigge table always accessible
wgrib2/Tigge.c Removes USE_TIGGE guards and the conditional error branch, making tigge functionality unconditional
wgrib2/Config.c Removes output messages about USE_MYSQL and USE_TIGGE from configuration display
CMakeLists.txt Removes option declarations for USE_TIGGE, USE_MYSQL, USE_WMO_VALIDATION, and DISABLE_TIMEZONE
docs/user_guide.md Removes documentation for the removed build options
spack/package.py Adds version constraints (@:3.8) to deprecated variants so they only apply to older versions
extra/CMakeLists.txt Implements automatic MySQL detection with find_package instead of manual configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlysonStahl-NOAA AlysonStahl-NOAA changed the title Remove some unused buid options Remove some unused build options Jan 30, 2026
@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review January 30, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant