Skip to content

Conversation

@grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Jul 15, 2025

Description

See https://docs.google.com/presentation/d/1LJbCrCVGYDvm0UPo8SR4KP6fT1VFocg-xLG399qGQ1w/edit?slide=id.g371ddcb3c06_0_238#slide=id.g371ddcb3c06_0_238 for a complete description.

Main points:

  • Converts all primary schemes to return tendencies rather than modify the physics state
  • Adds code to interstitial schemes to apply tendencies based on control from the host
  • Other minor changes (including lots of metadata changes) to implement the above
  • Obsolete schemes removed:
    • GFS_MP_generic_pre.F90
    • GFS_DCNV_generic_pre.F90
    • GFS_SCNV_generic_pre.F90
    • GFS_suite_stateout_reset.F90
    • GFS_suite_stateout_update.F90
    • mp_tempo_pre.F90
    • mp_thompson_pre.F90
  • New schemes:
    • GFS_photochemistry_post.F90 (because there was no generic interstitial scheme for this to apply tendencies)
    • mynnedmf_wrapper_post.F90 (because it doesn't use GFS_PBL_generic_post.F90)

For this repo, the main changes are:

  • removal of obsolete schemes in SDFs and ccpp_prebuild_config.py
  • addition of new interstitial schemes in SDFs and ccpp_prebuild_config.py
  • changed metadata in GFS/CCPP_typedefs
  • new tendency control variables in GFS_typedefs/GFS_control DDT
  • new tendency variables in CCPP_typedefs/GFS_interstitial DDT

Issue(s) addressed

None

Testing

See the linked slides. This was tested in the following ways:

  • standard UFS regression tests (should change baseline results for most/all tests that actually run physics, although changes SHOULD be similar to a compiler change; scientific results should NOT change)
  • SCM tests comparing selected suites before/after differences to compiler/debug mode differences
  • UFS tests comparing selected suites before/after differences to compiler/debug mode differences

Additional testing will be done by EMC when they have resources to check for unintended scientific result changes.

Dependencies

ufs-community/ccpp-physics#299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant