Sync NCAR/main branch of CCPP physics with ufs/dev branch#1092
Open
grantfirl wants to merge 10 commits intoNOAA-EMC:developfrom
Open
Sync NCAR/main branch of CCPP physics with ufs/dev branch#1092grantfirl wants to merge 10 commits intoNOAA-EMC:developfrom
grantfirl wants to merge 10 commits intoNOAA-EMC:developfrom
Conversation
32 tasks
…AR#17) Add RRTMGP initialization flags and revert hardcoding of mpiroot.
Collaborator
|
Could we get reviews on this PR soon so that we can begin testing the parent PR (ufs-community/ufs-weather-model#3190) today or tomorrow? |
DusanJovic-NOAA
approved these changes
May 5, 2026
dpsarmie
requested changes
May 6, 2026
| logical :: top_at_1 !< Vertical ordering flag. | ||
| integer :: iSFC !< Vertical index for surface | ||
| integer :: iTOA !< Vertical index for TOA | ||
| logical :: is_init_lw_gas_optics = .false. |
Collaborator
There was a problem hiding this comment.
Can a short comments be added to describe the variables to keep this similar with the rest of the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is primarily just a CCPP physics update, although it contains some host-side metadata changes to work with the ccpp-physics changes. See ufs-community/ccpp-physics#369 for a description of the CCPP-physics changes.
Issue(s) addressed
None
Testing
UFS RTs on Ursa
Dependencies
ufs-community/ccpp-physics#369